Messages in this thread | | | From | Tyrone Ting <> | Date | Thu, 9 Jun 2022 20:59:44 +0800 | Subject | Re: [PATCH v6 2/5] i2c: npcm: Remove own slave addresses 2:10 |
| |
Hi Wolfram:
Thank you for your review and comments.
Wolfram Sang <wsa@kernel.org> 於 2022年6月9日 週四 上午4:02寫道: > > On Wed, May 25, 2022 at 11:23:38AM +0800, Tyrone Ting wrote: > > From: Tali Perry <tali.perry1@gmail.com> > > > > NPCM can support up to 10 own slave addresses. In practice, only one > > address is actually being used. In order to access addresses 2 and above, > > need to switch register banks. The switch needs spinlock. > > To avoid using spinlock for this useless feature removed support of SA >= > > 2. Also fix returned slave event enum. > > > > Remove some comment since the bank selection is not required. The bank > > selection is not required since the supported slave addresses are reduced. > > > > Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver") > > Signed-off-by: Tali Perry <tali.perry1@gmail.com> > > Signed-off-by: Tyrone Ting <kfting@nuvoton.com> > > Applied to for-next, thanks! >
Best Regards, Tyrone
| |