lkml.org 
[lkml]   [2022]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH AUTOSEL 5.18 31/68] accessiblity: speakup: Add missing misc_deregister in softsynth_probe
Sasha Levin, le mar. 07 juin 2022 13:47:57 -0400, a ecrit:
> From: Zheng Bin <zhengbin13@huawei.com>
>
> [ Upstream commit 106101303eda8f93c65158e5d72b2cc6088ed034 ]
>
> softsynth_probe misses a call misc_deregister() in an error path, this
> patch fixes that.
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> Link: https://lore.kernel.org/r/20220511032937.2736738-1-zhengbin13@huawei.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
> drivers/accessibility/speakup/speakup_soft.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/accessibility/speakup/speakup_soft.c b/drivers/accessibility/speakup/speakup_soft.c
> index 19824e7006fe..786dc5d080f3 100644
> --- a/drivers/accessibility/speakup/speakup_soft.c
> +++ b/drivers/accessibility/speakup/speakup_soft.c
> @@ -397,6 +397,7 @@ static int softsynth_probe(struct spk_synth *synth)
> synthu_device.name = "softsynthu";
> synthu_device.fops = &softsynthu_fops;
> if (misc_register(&synthu_device)) {
> + misc_deregister(&synth_device);
> pr_warn("Couldn't initialize miscdevice /dev/softsynthu.\n");
> return -ENODEV;
> }
> --
> 2.35.1
>

--
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.

\
 
 \ /
  Last update: 2022-06-09 14:30    [W:0.346 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site