lkml.org 
[lkml]   [2022]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH printk v5 1/1] printk: extend console_lock for per-console locking
    On Thu, 9 Jun 2022 at 13:59, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
    >
    > Hi John,
    >
    > On Thu, Jun 09, 2022 at 01:25:15PM +0206, John Ogness wrote:
    > > (Added RANDOM NUMBER DRIVER and KFENCE people.)
    >
    > Thanks.
    >
    > > I am guessing you have CONFIG_PROVE_RAW_LOCK_NESTING enabled?
    > >
    > > We are seeing a spinlock (base_crng.lock) taken while holding a
    > > raw_spinlock (meta->lock).
    > >
    > > kfence_guarded_alloc()
    > > raw_spin_trylock_irqsave(&meta->lock, flags)
    > > prandom_u32_max()
    > > prandom_u32()
    > > get_random_u32()
    > > get_random_bytes()
    > > _get_random_bytes()
    > > crng_make_state()
    > > spin_lock_irqsave(&base_crng.lock, flags);
    > >
    > > I expect it is allowed to create kthreads via kthread_run() in
    > > early_initcalls.
    >
    > AFAIK, CONFIG_PROVE_RAW_LOCK_NESTING is useful for teasing out cases
    > where RT's raw spinlocks will nest wrong with RT's sleeping spinlocks.
    > But nobody who wants an RT kernel will be using KFENCE. So this seems
    > like a non-issue? Maybe just add a `depends on !KFENCE` to
    > PROVE_RAW_LOCK_NESTING?

    Don't know if there are other good solutions (of similar simplicity).
    But fwiw this is not about the target production environment. Real
    production uses of RT kernels will probably not enable LOCKDEP,
    PROVE_RAW_LOCK_NESTING and other debugging configs.
    This is about detecting as many bugs as possible in testing
    environments. And testing environments can well have both LOCKDEP and
    KFENCE enabled. Any such limitation will require doubling the number
    of tested configurations.

    Btw, should this new CONFIG_PROVE_RAW_LOCK_NESTING be generally
    enabled on testing systems? We don't have it enabled on syzbot.

    \
     
     \ /
      Last update: 2022-06-09 14:20    [W:3.240 / U:0.520 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site