Messages in this thread | | | Date | Thu, 9 Jun 2022 11:35:46 +0200 | Subject | Re: [PATCH v3 1/2] dt-bindings: timer: mediatek: Add CPUX System Timer and MT6795 compatible | From | AngeloGioacchino Del Regno <> |
| |
Il 07/06/22 18:11, Matthias Brugger ha scritto: > > > On 18/05/2022 13:24, AngeloGioacchino Del Regno wrote: >> Document the "CPUXGPT" CPU General Purpose Timer, used as ARM/ARM64 >> System Timer on MediaTek platforms and add the MT6795 compatible for it. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> .../devicetree/bindings/timer/mediatek,mtk-timer.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt >> b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt >> index 6f1f9dba6e88..49706cbef45d 100644 >> --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt >> +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt >> @@ -2,6 +2,7 @@ MediaTek Timers >> --------------- >> MediaTek SoCs have two different timers on different platforms, > > Nit: There are now three different timers so maybe: > "MediaTek SoCs have different timers on different platforms," > > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> >
Hi Matthias, can we please ignore that description nit for this patch?
I was anyway planning to do a YAML conversion after getting this merged in, perhaps we can just fix that on the new one instead?
Cheers, Angelo
>> +- CPUX (ARM/ARM64 System Timer) >> - GPT (General Purpose Timer) >> - SYST (System Timer) >> @@ -29,6 +30,9 @@ Required properties: >> * "mediatek,mt7629-timer" for MT7629 compatible timers (SYST) >> * "mediatek,mt6765-timer" for MT6765 and all above compatible timers (SYST) >> + For those SoCs that use CPUX >> + * "mediatek,mt6795-systimer" for MT6795 compatible timers (CPUX) >> + >> - reg: Should contain location and length for timer register. >> - clocks: Should contain system clock.
| |