Messages in this thread | | | Date | Wed, 8 Jun 2022 22:04:57 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH RFC v1 1/7] swiotlb: introduce the highmem swiotlb buffer |
| |
On Wed, Jun 08, 2022 at 05:55:47PM -0700, Dongli Zhang wrote: > @@ -109,6 +109,7 @@ struct io_tlb_mem { > } *slots; > }; > extern struct io_tlb_mem io_tlb_default_mem; > +extern struct io_tlb_mem io_tlb_high_mem;
Tis should not be exposed.
> +extern bool swiotlb_high_active(void);
And this should not even exist.
> +static unsigned long high_nslabs;
And I don't think "high" is a good name here to start with. That suggests highmem, which we are not using here.
| |