lkml.org 
[lkml]   [2022]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v10 18/21] drm/mediatek: Add mt8195 Embedded DisplayPort driver
From
Date
On Tue, 2022-06-07 at 16:01 +0800, CK Hu wrote:
> Hi, Rex:
>
> On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote:
> > From: Markus Schneider-Pargmann <msp@baylibre.com>
> >
> > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC.
> >
> > It supports the mt8195, the embedded DisplayPort units. It offers
> > DisplayPort 1.4 with up to 4 lanes.
> >
> > The driver creates a child device for the phy. The child device
> > will
> > never exist without the parent being active. As they are sharing a
> > register range, the parent passes a regmap pointer to the child so
> > that
> > both can work with the same register range. The phy driver sets
> > device
> > data that is read by the parent to get the phy device that can be
> > used
> > to control the phy properties.
> >
> > This driver is based on an initial version by
> > Jason-JH.Lin <jason-jh.lin@mediatek.com>.
> >
> > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> > ---
>
> [snip]
>
> > +
> > +static void mtk_dp_state_handler(struct mtk_dp *mtk_dp)
> > +{
> > + switch (mtk_dp->state) {
>
> Does mtk_dp->state has any relation with mtk_dp->train_state. If yes,
> mix mtk_dp->state and mtk_dp->train_state into one state. If no, move
> calling mtk_dp_state_handler() out of mtk_dp_train_handler().
>
> Regards,
> CK
>

Hello CK,

OK, I will refine this flow.
About the state machine of traning flow, we can review in v11.

BRs,
Bo-Chen

> > + case MTK_DP_STATE_INITIAL:
> > + mtk_dp_video_mute(mtk_dp, true);
> > + mtk_dp->state = MTK_DP_STATE_IDLE;
> > + break;
> > +
> > + case MTK_DP_STATE_IDLE:
> > + if (mtk_dp->train_state == MTK_DP_TRAIN_STATE_NORMAL)
> > + mtk_dp->state = MTK_DP_STATE_PREPARE;
> > + break;
> > +
> > + case MTK_DP_STATE_PREPARE:
> > + mtk_dp_video_config(mtk_dp);
> > + mtk_dp_video_enable(mtk_dp, true);
> > +
> > + mtk_dp->state = MTK_DP_STATE_NORMAL;
> > + break;
> > +
> > + case MTK_DP_STATE_NORMAL:
> > + if (mtk_dp->train_state != MTK_DP_TRAIN_STATE_NORMAL) {
> > + mtk_dp_video_mute(mtk_dp, true);
> > + mtk_dp->state = MTK_DP_STATE_IDLE;
> > + }
> > + break;
> > +
> > + default:
> > + break;
> > + }
> > +}
>
>

\
 
 \ /
  Last update: 2022-06-09 09:19    [W:0.274 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site