Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH v5 3/4] fat: add renameat2 RENAME_EXCHANGE flag support | Date | Fri, 10 Jun 2022 12:17:24 +0900 |
| |
Javier Martinez Canillas <javierm@redhat.com> writes:
>> >> Looks like unnecessary complex (and comparing raw i_mode, not S_ISDIR(), >> better to change before make dir dirty). How about this change, it is >> only tested slightly though? Can you review and test? >> > > Your change looks good to me and indeed the logic is simpler than in mine. > > I've also tested it and AFAICT it works correctly as well. Do you plan to > squash this or should I respin a new revision of the whole patch-set ? If > you want to post it as a follow-up I'm also OK with that.
Could you merge to your patchset, and re-send?
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |