lkml.org 
[lkml]   [2022]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v5 3/4] fat: add renameat2 RENAME_EXCHANGE flag support
    Date
    Javier Martinez Canillas <javierm@redhat.com> writes:

    >>
    >> Looks like unnecessary complex (and comparing raw i_mode, not S_ISDIR(),
    >> better to change before make dir dirty). How about this change, it is
    >> only tested slightly though? Can you review and test?
    >>
    >
    > Your change looks good to me and indeed the logic is simpler than in mine.
    >
    > I've also tested it and AFAICT it works correctly as well. Do you plan to
    > squash this or should I respin a new revision of the whole patch-set ? If
    > you want to post it as a follow-up I'm also OK with that.

    Could you merge to your patchset, and re-send?

    Thanks.
    --
    OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

    \
     
     \ /
      Last update: 2022-06-10 05:18    [W:3.704 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site