lkml.org 
[lkml]   [2022]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] dt-bindings: leds: skyworks,aat1290: convert to dtschema
From
Hi Krzysztof,

On 6/7/22 10:53, Krzysztof Kozlowski wrote:
> Convert the Skyworks Solutions, Inc. AAT1290 Current Regulator bindings
> to DT Schema.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
[...]
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/leds/common.h>
> +
> + // Ct = 220 nF, Rset = 160 kOhm
> + led-controller {
> + compatible = "skyworks,aat1290";
> + flen-gpios = <&gpj1 1 GPIO_ACTIVE_HIGH>;
> + enset-gpios = <&gpj1 2 GPIO_ACTIVE_HIGH>;
> +
> + pinctrl-names = "default", "host", "isp";
> + pinctrl-0 = <&camera_flash_host>;
> + pinctrl-1 = <&camera_flash_host>;
> + pinctrl-2 = <&camera_flash_isp>;
> +
> + led {
> + label = "flash";

Why are you adding label? It is deprecated, but has the precedence over
new function and color for backwards compatibility, so it would make
those unused by the driver now. Please drop the label from this example.

> + function = LED_FUNCTION_FLASH;
> + color = <LED_COLOR_ID_WHITE>;
> + led-max-microamp = <520833>;
> + flash-max-microamp = <1012500>;
> + flash-max-timeout-us = <1940000>;
> + };
> + };

--
Best regards,
Jacek Anaszewski

\
 
 \ /
  Last update: 2022-06-09 22:29    [W:1.664 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site