Messages in this thread | | | Date | Thu, 9 Jun 2022 19:05:43 +0200 | Subject | Re: [PATCH] certs: Convert spaces in certs/Makefile to a tab | From | Mickaël Salaün <> |
| |
On 06/06/2022 14:31, David Howells wrote: > There's a rule in certs/Makefile for which the command begins with eight > spaces. This results in: > > ../certs/Makefile:21: FORCE prerequisite is missing > ../certs/Makefile:21: *** missing separator. Stop. > > Fix this by turning the spaces into a tab.
These spaces were not part of my patch but they are indeed in this file now: https://lore.kernel.org/r/20210712170313.884724-3-mic@digikod.net
Reviewed-by: Mickaël Salaün <mic@linux.microsoft.com>
> > Fixes: addf466389d9 ("certs: Check that builtin blacklist hashes are valid") > Signed-off-by: David Howells <dhowells@redhat.com> > cc: Mickaël Salaün <mic@linux.microsoft.com> > cc: Jarkko Sakkinen <jarkko@kernel.org> > cc: keyrings@vger.kernel.org > --- > > certs/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/certs/Makefile b/certs/Makefile > index bb904f90f139..cb1a9da3fc58 100644 > --- a/certs/Makefile > +++ b/certs/Makefile > @@ -18,7 +18,7 @@ CFLAGS_blacklist_hashes.o += -I$(srctree) > > targets += blacklist_hashes_checked > $(obj)/blacklist_hashes_checked: $(SYSTEM_BLACKLIST_HASH_LIST_SRCPREFIX)$(SYSTEM_BLACKLIST_HASH_LIST_FILENAME) scripts/check-blacklist-hashes.awk FORCE > - $(call if_changed,check_blacklist_hashes,$(SYSTEM_BLACKLIST_HASH_LIST_SRCPREFIX)$(CONFIG_SYSTEM_BLACKLIST_HASH_LIST)) > + $(call if_changed,check_blacklist_hashes,$(SYSTEM_BLACKLIST_HASH_LIST_SRCPREFIX)$(CONFIG_SYSTEM_BLACKLIST_HASH_LIST)) > obj-$(CONFIG_SYSTEM_BLACKLIST_KEYRING) += blacklist_hashes.o > else > obj-$(CONFIG_SYSTEM_BLACKLIST_KEYRING) += blacklist_nohashes.o > >
| |