Messages in this thread | | | From | Hongxing Zhu <> | Subject | RE: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage | Date | Thu, 9 Jun 2022 06:19:47 +0000 |
| |
> -----Original Message----- > From: Bjorn Helgaas <helgaas@kernel.org> > Sent: 2022年6月9日 2:55 > To: Hongxing Zhu <hongxing.zhu@nxp.com> > Cc: l.stach@pengutronix.de; bhelgaas@google.com; robh+dt@kernel.org; > broonie@kernel.org; lorenzo.pieralisi@arm.com; jingoohan1@gmail.com; > festevam@gmail.com; francesco.dolcini@toradex.com; > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx > <linux-imx@nxp.com> > Subject: Re: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage > > On Fri, May 06, 2022 at 09:47:06AM +0800, Richard Zhu wrote: > > The driver should undo any enables it did itself. The regulator > > disable shouldn't be basing decisions on regulator_is_enabled(). > > > > To keep the balance of the regulator usage counter, disable the > > regulator just behind of imx6_pcie_assert_core_reset() in resume and > shutdown. > > In subject, "Refine" doesn't tell me anything about what's happening here. Thanks for your comments. How about the following one? PCI: imx6: Do regulator disable without the regulator_is_enabled check
Best Regards Richard Zhu
| |