Messages in this thread Patch in this message | | | Date | Thu, 09 Jun 2022 16:50:28 -0000 | From | "irqchip-bot for Miaoqian Lin" <> | Subject | [irqchip: irq/irqchip-fixes] irqchip/apple-aic: Fix refcount leak in build_fiq_affinity |
| |
The following commit has been merged into the irq/irqchip-fixes branch of irqchip:
Commit-ID: b1ac803f47cb1615468f35cf1ccb553c52087301 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/b1ac803f47cb1615468f35cf1ccb553c52087301 Author: Miaoqian Lin <linmq006@gmail.com> AuthorDate: Wed, 01 Jun 2022 12:09:26 +04:00 Committer: Marc Zyngier <maz@kernel.org> CommitterDate: Thu, 09 Jun 2022 17:36:57 +01:00
irqchip/apple-aic: Fix refcount leak in build_fiq_affinity
of_find_node_by_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.
Fixes: a5e8801202b3 ("irqchip/apple-aic: Parse FIQ affinities from device-tree") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20220601080930.31005-3-linmq006@gmail.com --- drivers/irqchip/irq-apple-aic.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c index 12dd487..478d0af 100644 --- a/drivers/irqchip/irq-apple-aic.c +++ b/drivers/irqchip/irq-apple-aic.c @@ -1035,6 +1035,7 @@ static void build_fiq_affinity(struct aic_irq_chip *ic, struct device_node *aff) continue; cpu = of_cpu_node_to_id(cpu_node); + of_node_put(cpu_node); if (WARN_ON(cpu < 0)) continue;
| |