lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V14 7/9] regulator: Add a regulator driver for the PM8008 PMIC
Hi Satya,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on lee-mfd/for-mfd-next]
[also build test WARNING on robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Satya-Priya/Add-Qualcomm-Technologies-Inc-PM8008-regulator-driver/20220607-195327
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220608/202206080910.XAMKbeVH-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/11e915cb6368e90fdc4186104c56a3619aa63440
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Satya-Priya/Add-Qualcomm-Technologies-Inc-PM8008-regulator-driver/20220607-195327
git checkout 11e915cb6368e90fdc4186104c56a3619aa63440
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/regulator/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/regulator/qcom-pm8008-regulator.c: In function 'pm8008_regulator_get_voltage':
>> drivers/regulator/qcom-pm8008-regulator.c:74:13: warning: unused variable 'rc' [-Wunused-variable]
74 | int rc, uV;
| ^~


vim +/rc +74 drivers/regulator/qcom-pm8008-regulator.c

69
70 static int pm8008_regulator_get_voltage(struct regulator_dev *rdev)
71 {
72 struct pm8008_regulator *pm8008_reg = rdev_get_drvdata(rdev);
73 __le16 mV;
> 74 int rc, uV;
75
76 regmap_bulk_read(pm8008_reg->regmap,
77 LDO_VSET_LB_REG(pm8008_reg->base), (void *)&mV, 2);
78
79 uV = le16_to_cpu(mV) * 1000;
80 return (uV - pm8008_reg->rdesc.min_uV) / pm8008_reg->rdesc.uV_step;
81 }
82

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-06-08 06:20    [W:0.496 / U:1.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site