Messages in this thread | | | Date | Wed, 8 Jun 2022 14:49:07 +0200 | From | "Jason A. Donenfeld" <> | Subject | Re: [PATCH] splice: allow direct splicing with chardevs |
| |
Hey again,
On Thu, May 26, 2022 at 11:19:46PM +0200, Jason A. Donenfeld wrote: > Hey Al, > > On 5/20/22, Jens Axboe <axboe@kernel.dk> wrote: > > On 5/20/22 3:57 AM, Jason A. Donenfeld wrote: > >> The original direct splicing mechanism from Jens required the input to > >> be a regular file because it was avoiding the special socket case. It > >> also recognized blkdevs as being close enough to a regular file. But it > >> forgot about chardevs, which behave the same way and work fine here. > >> > >> This commit adds the missing S_ISCHR condition so that chardevs such as > >> /dev/urandom can be directly spliced without strangely returning > >> -EINVAL. > > > > Should be fine to turn this on for char devices: > > > > Reviewed-by: Jens Axboe <axboe@kernel.dk> > > > > Was wondering if this would make 5.19. That'd be nice, as it's the > release in which we switch to read_iter().
Just thought I should ping once more on this. Should probably be queued up somewhat soon for 5.19 if it's to make 5.19, which I would really appreciate.
Jason
| |