lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/2] spi: Use device_find_first_child() instead of custom approach
On Wed, Jun 08, 2022 at 02:03:32PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 08, 2022 at 02:49:14PM +0300, Andy Shevchenko wrote:

...

> Why not exactly? match_true() above and device_match_any() have the
> same signature from what I can tell:
> static int match_true(struct device *dev, void *data)
> int device_match_any(struct device *dev, const void *unused)
>
> What am I missing, the const?

Yep! Compiler is very unhappy about it.

> > I agree that all thing should be using _any instead of _first.
>
> Yes, so let's fix it please, don't propagate bad patterns.

Will do, thanks!

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2022-06-08 14:30    [W:0.074 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site