lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 2/2] spi: Use device_find_first_child() instead of custom approach
On Tue, Jun 7, 2022 at 10:22 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> We have already a helper to get the first child device, use it and
> drop custom approach.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Nice cleanup.

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> ---
> drivers/spi/spi.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index ea09d1b42bf6..87dc8773108b 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -2613,11 +2613,6 @@ int spi_slave_abort(struct spi_device *spi)
> }
> EXPORT_SYMBOL_GPL(spi_slave_abort);
>
> -static int match_true(struct device *dev, void *data)
> -{
> - return 1;
> -}
> -
> static ssize_t slave_show(struct device *dev, struct device_attribute *attr,
> char *buf)
> {
> @@ -2625,7 +2620,7 @@ static ssize_t slave_show(struct device *dev, struct device_attribute *attr,
> dev);
> struct device *child;
>
> - child = device_find_child(&ctlr->dev, NULL, match_true);
> + child = device_find_first_child(&ctlr->dev);
> return sprintf(buf, "%s\n",
> child ? to_spi_device(child)->modalias : NULL);
> }
> @@ -2644,7 +2639,7 @@ static ssize_t slave_store(struct device *dev, struct device_attribute *attr,
> if (rc != 1 || !name[0])
> return -EINVAL;
>
> - child = device_find_child(&ctlr->dev, NULL, match_true);
> + child = device_find_first_child(&ctlr->dev);
> if (child) {
> /* Remove registered slave */
> device_unregister(child);
> --
> 2.35.1
>

\
 
 \ /
  Last update: 2022-06-08 13:32    [W:0.147 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site