Messages in this thread | | | Date | Wed, 8 Jun 2022 02:17:33 +0000 | From | Tzung-Bi Shih <> | Subject | Re: [PATCH v2 15/15] platform/chrome: cros_ec_proto: return 0 on getting wake mask success |
| |
On Tue, Jun 07, 2022 at 12:12:25PM -0700, Guenter Roeck wrote: > On Tue, Jun 7, 2022 at 7:57 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > > > cros_ec_get_host_event_wake_mask() used to return value from > > send_command() which is number of bytes for input payload on success > > (i.e. sizeof(struct ec_response_host_event_mask)). > > > > However, the callers don't need to know how many bytes are available. > > > > - Fix cros_ec_get_host_event_wake_mask() to return 0 on success; > > negative integers on error. > > > > - Add a Kunit test for guarding if send_command() returns 0 in > > get_host_event_wake_mask(). > > > Please split into two patches.
Ack.
| |