Messages in this thread | | | Date | Wed, 8 Jun 2022 02:17:23 +0000 | From | Tzung-Bi Shih <> | Subject | Re: [PATCH v2 14/15] platform/chrome: cros_ec_proto: return 0 on getting version mask success |
| |
On Tue, Jun 07, 2022 at 12:11:23PM -0700, Guenter Roeck wrote: > On Tue, Jun 7, 2022 at 7:57 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > > > cros_ec_get_host_command_version_mask() used to return value from > > send_command() which is number of bytes for input payload on success > > (i.e. sizeof(struct ec_response_get_cmd_versions)). > > > > However, the callers don't need to know how many bytes are available. > > > > - Fix cros_ec_get_host_command_version_mask() to return 0 on success; > > negative integers on error. > > > > - Remove the unneeded `ver_mask` initialization as the callers should > > take it only if cros_ec_get_host_command_version_mask() returns 0. > > > > - Add a Kunit test: `ver_mask` has some garbage bytes from previous > > EC_CMD_GET_NEXT_EVENT but there is no host sleep to make sure the > > caller checks the return values correctly. > > > This should be separate patches.
Ack. Will fix in next version.
| |