lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 3/6] mm: Ratelimited mirrored memory related warning messages
From


On 6/7/22 15:08, Wupeng Ma wrote:
> From: Ma Wupeng <mawupeng1@huawei.com>
>
> If system has mirrored memory, memblock will try to allocate mirrored
> memory firstly and fallback to non-mirrored memory when fails, but if with
> limited mirrored memory or some numa node without mirrored memory, lots of
> warning message about memblock allocation will occur.
>
> This patch ratelimit the warning message to avoid a very long print during
> bootup.
>
> Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
> ---
> mm/memblock.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index e4f03a6e8e56..b1d2a0009733 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -327,7 +327,7 @@ static phys_addr_t __init_memblock memblock_find_in_range(phys_addr_t start,
> NUMA_NO_NODE, flags);
>
> if (!ret && (flags & MEMBLOCK_MIRROR)) {
> - pr_warn("Could not allocate %pap bytes of mirrored memory\n",
> + pr_warn_ratelimited("Could not allocate %pap bytes of mirrored memory\n",
> &size);
> flags &= ~MEMBLOCK_MIRROR;
> goto again;
> @@ -1384,7 +1384,7 @@ phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size,
>
> if (flags & MEMBLOCK_MIRROR) {
> flags &= ~MEMBLOCK_MIRROR;
> - pr_warn("Could not allocate %pap bytes of mirrored memory\n",
> + pr_warn_ratelimited("Could not allocate %pap bytes of mirrored memory\n",
> &size);
> goto again;
> }

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

\
 
 \ /
  Last update: 2022-06-08 12:16    [W:0.199 / U:2.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site