lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 0/4] Add support for XP-PEN Deco L
On Mon, 6 Jun 2022, José Expósito wrote:

> > This patchset adds support for the UGEE XP-PEN Deco L tablet.
> > This device belongs to a family of tablets that must receive a chunk of
> > magic data in order to be enabled (named UGEE v2 internally).
> >
> > [...]
> >
> > ---
> >
> > v1 - Initial version
> > https://lore.kernel.org/linux-input/20220518224702.1409327-1-jose.exposito89@gmail.com/
> >
> > v2 - Fix some errors reported by the kernel test robot:
> >
> > - Add MODULE_DESCRIPTION/LICENSE/AUTHOR to hid-uclogic-rdesc-test.c
> > - Remove unused variable in uclogic_params_ugee_v2_init
> > - Add sparse __force anotation in the result of cpu_to_le16
> > - Add DISABLE_STRUCTLEAK_PLUGIN for KUnit tests
> >
> > https://lore.kernel.org/linux-input/20220518224702.1409327-1-jose.exposito89@gmail.com/T/
> >
> > v3 - This version:
> >
> > - Improve Kconfig message
> > - Add .kunitconfig. Thanks to Daniel Latypov for suggesting it in an
> > unrelated patch:
> > https://lore.kernel.org/dri-devel/CAGS_qxpV2SsihEdgXZ6+7N0dxLmdRANq+qE4iUZ2aNrf6vuLYg@mail.gmail.com/
>
> As mentioned in the v3 changelog, I'm working on a DRM patch including
> a few KUnit tests [1].
>
> Some interesting highlights from the comments there:
>
> - It looks like the maintainers prefer to include a single symbol [2]
> to enable all tests in the subsystem.
>
> Jiří, Benjamin, how would you like to handle it? Would you prefer to
> have a symbol for each test (HID_UCLOGIC_KUNIT_TEST)? Or a symbol for
> all tests (HID_KUNIT_TEST)?

I don't really see any benefit in breaking it down to per-driver tests, so
yes, please hide it all under one unified HID_KUNIT_TEST as far as I am
concerned.

Thanks,

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2022-06-08 12:12    [W:0.092 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site