Messages in this thread | | | Date | Wed, 8 Jun 2022 10:50:06 +0200 | From | Vasant Karasulli <> | Subject | Re: [PATCH v6 2/4] x86/tests: Add tests for AMD SEV-ES #VC handling Add KUnit based tests to validate Linux's VC handling for instructions cpuid and wbinvd. These tests: 1. install a kretprobe on the #VC handler (sev_es_ghcb_hv_call, to access GHCB befor |
| |
On Mi 06-04-22 01:22:55, Sean Christopherson wrote: > > + if (ret) { > > + kunit_info(test, "Could not register kretprobe. Skipping."); > > + goto out; > > + } > > + > > + test->priv = kunit_kzalloc(test, sizeof(u64), GFP_KERNEL); > > Allocating 8 bytes and storing the pointer an 8-byte field is rather pointless :-) >
Actually it's necessary to allocate memory to test->priv before using according to https://www.kernel.org/doc/html/latest/dev-tools/kunit/tips.html
> > + if (!test->priv) { > > + ret = -ENOMEM; > > + kunit_info(test, "Could not allocate. Skipping."); > > + goto out; > > + } > > +
-- Vasant Karasulli Kernel generalist www.suse.com<http://www.suse.com> [https://www.suse.com/assets/img/social-platforms-suse-logo.png]<http://www.suse.com/> SUSE - Open Source Solutions for Enterprise Servers & Cloud<http://www.suse.com/> Modernize your infrastructure with SUSE Linux Enterprise servers, cloud technology for IaaS, and SUSE's software-defined storage. www.suse.com
| |