Messages in this thread Patch in this message | | | From | Xiaohui Zhang <> | Subject | [PATCH 1/1] platform/x86/intel: Fix uninitialized entry in pmt_crashlog_probe | Date | Wed, 8 Jun 2022 09:17:12 +0800 |
| |
Similar to the handling of pmt_telem_probe in commit 2cdfa0c20d58 ("platform/x86/intel: Fix 'rmmod pmt_telemetry' panic"), we thought a patch might be needed here as well.
The probe function, pmt_crashlog_probe(), adds an entry for devices even if they have not been initialized. This results in the array of initialized devices containing both initialized and uninitialized entries. This causes a panic in the remove function, pmt_crashlog_remove() which expects the array to only contain initialized entries.
Only use an entry when a device is initialized.
Signed-off-by: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn> --- drivers/platform/x86/intel/pmt/crashlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel/pmt/crashlog.c b/drivers/platform/x86/intel/pmt/crashlog.c index 34daf9df168b..ace1239bc0a0 100644 --- a/drivers/platform/x86/intel/pmt/crashlog.c +++ b/drivers/platform/x86/intel/pmt/crashlog.c @@ -282,7 +282,7 @@ static int pmt_crashlog_probe(struct auxiliary_device *auxdev, auxiliary_set_drvdata(auxdev, priv); for (i = 0; i < intel_vsec_dev->num_resources; i++) { - struct intel_pmt_entry *entry = &priv->entry[i].entry; + struct intel_pmt_entry *entry = &priv->entry[priv->num_entries].entry; ret = intel_pmt_dev_create(entry, &pmt_crashlog_ns, intel_vsec_dev, i); if (ret < 0) -- 2.17.1
| |