lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/7] dt-bindings: usb: Add Type-C switch binding
From
On 07/06/2022 21:00, Prashant Malani wrote:
> Introduce a binding which represents a component that can control the
> routing of USB Type-C data lines as well as address data line
> orientation (based on CC lines' orientation).
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> ---
> .../devicetree/bindings/usb/typec-switch.yaml | 76 +++++++++++++++++++
> 1 file changed, 76 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/typec-switch.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/typec-switch.yaml b/Documentation/devicetree/bindings/usb/typec-switch.yaml
> new file mode 100644
> index 000000000000..60a600a63fef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/typec-switch.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/typec-switch.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: USB Type-C Switch
> +
> +maintainers:
> + - Prashant Malani <pmalani@chromium.org>
> +
> +description:
> + A USB Type-C switch represents a component which routes USB Type-C data
> + lines to various protocol host controllers (e.g USB, VESA DisplayPort,
> + Thunderbolt etc.) depending on which mode the Type-C port, port partner
> + and cable are operating in. It can also modify lane routing based on
> + the orientation of a connected Type-C peripheral.
> +
> +properties:
> + compatible:
> + items:

Single item, so no need for items.

> + - enum:
> + - typec-switch
> +
> + mode-switch:
> + type: boolean
> + description: Specify that this switch can handle alternate mode switching.
> +
> + orientation-switch:
> + type: boolean
> + description: Specify that this switch can handle orientation switching.
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> + description: OF graph binding modelling data lines to the Type-C switch.
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Link between the switch and a Type-C connector.
> +
> + required:
> + - port@0
> +
> +required:
> + - compatible
> + - ports
> +
> +anyOf:
> + - required:
> + - mode-switch
> + - required:
> + - orientation-switch
> +
> +additionalProperties: true

Why true? I see usb-connector has it from commit 6a0e321ea735
("dt-bindings: Explicitly allow additional properties in common schemas")
but that looks also weird - this is not a common schema, but a
complete, generic one.

> +
> +examples:
> + - |
> + anx7625 {

Generic node name.

> + typecswitch {

I guess here as well, so "usb-switch"?

> + compatible = "typec-switch";
> + mode-switch;
> + orientation-switch;
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + anx_ep: endpoint {
> + remote-endpoint = <&typec_controller>;
> + };
> + };
> + };
> + };
> + };


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-17 16:25    [W:1.165 / U:1.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site