lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/10] vmscan: Add check_move_unevictable_folios()
    On Wed, Jun 08, 2022 at 05:32:34PM +0100, Matthew Wilcox wrote:
    > On Wed, Jun 08, 2022 at 01:07:32AM -0700, Christoph Hellwig wrote:
    > > On Sun, Jun 05, 2022 at 08:38:52PM +0100, Matthew Wilcox (Oracle) wrote:
    > > > Change the guts of check_move_unevictable_pages() over to use folios
    > > > and add check_move_unevictable_pages() as a wrapper.
    > >
    > > The changes here look fine, but please also add patches for converting
    > > the two callers (which looks mostly trivial to me).
    >
    > I do want to get rid of pagevecs entirely, but that conversion isn't
    > going to happen in time for the next merge window. for_each_sgt_page()
    > is a little intimidating.

    for_each_sgt_page, just like other creative scatterlist abuse in the gpu
    code is a beast. But, instead of doing a for_each_sgt_page to add
    pages to the pagevec and then do a loop over the pagevec to add to
    the folio batch it should be pretty trivial to just cut out the
    middle man.

    \
     
     \ /
      Last update: 2022-06-09 05:58    [W:3.240 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site