Messages in this thread | | | Date | Thu, 9 Jun 2022 05:54:19 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/5] ext2: remove nobh support |
| |
On Wed, Jun 08, 2022 at 05:39:59PM +0100, Matthew Wilcox wrote: > On Wed, Jun 08, 2022 at 05:04:47PM +0200, Christoph Hellwig wrote: > > @@ -551,7 +548,8 @@ static int parse_options(char *options, struct super_block *sb, > > clear_opt (opts->s_mount_opt, OLDALLOC); > > break; > > case Opt_nobh: > > - set_opt (opts->s_mount_opt, NOBH); > > + ext2_msg(sb, KERN_INFO, > > + "nobh option not supported"); > > break; > > This is the only part I wonder about. Should we just silently accept > the nobh option instead of emitting a message?
That is how ext2 handles other ignores messages. Note that it still accepts the option, it just prints a short line in dmesg.
> Also, is it time to start emitting a message for nfs' intr option? ;-)
Talk to the nfs folks..
| |