Messages in this thread | | | Date | Wed, 8 Jun 2022 20:40:44 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next v2 2/2] net: phy: add remote fault support |
| |
On Wed, 8 Jun 2022 14:23:22 +0200 Oleksij Rempel wrote: > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 508f1149665b..94a95e60cb45 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -564,6 +564,7 @@ struct macsec_ops; > * @advertising: Currently advertised linkmodes > * @adv_old: Saved advertised while power saving for WoL > * @lp_advertising: Current link partner advertised linkmodes > + * @lp_remote_fault: Current link partner advertised remote fault > * @eee_broken_modes: Energy efficient ethernet modes which should be prohibited > * @autoneg: Flag autoneg being used > * @link: Current link state > @@ -646,6 +647,10 @@ struct phy_device { > u8 master_slave_set; > u8 master_slave_state; > > + u8 remote_fault_set; > + u8 remote_fault_get; > + u8 remote_fault_state;
./scripts/kernel-doc :
include/linux/phy.h:717: warning: Function parameter or member 'remote_fault_set' not described in 'phy_device' include/linux/phy.h:717: warning: Function parameter or member 'remote_fault_get' not described in 'phy_device' include/linux/phy.h:717: warning: Function parameter or member 'remote_fault_state' not described in 'phy_device' include/uapi/linux/ethtool.h:2139: warning: Function parameter or member 'remote_fault_cfg' not described in 'ethtool_link_settings' include/uapi/linux/ethtool.h:2139: warning: Function parameter or member 'remote_fault_state' not described in 'ethtool_link_settings'
| |