Messages in this thread | | | Subject | Re: [PATCH v6 2/8] ASoC: mediatek: mt8186: add platform driver | From | Jiaxin Yu <> | Date | Thu, 9 Jun 2022 10:58:42 +0800 |
| |
On Wed, 2022-06-08 at 12:24 +0100, Mark Brown wrote: > On Tue, Jun 07, 2022 at 10:20:40PM +0800, Jiaxin Yu wrote: > > > +obj-$(CONFIG_SND_SOC_MT8186) += snd-soc-mt8186-afe.o > > +obj-$(CONFIG_SND_SOC_MT8186_MT6366_DA7219_MAX98357) += mt8186- > > mt6366-da7219-max98357.o > > +obj-$(CONFIG_SND_SOC_MT8186_MT6366_RT1019_RT5682S) += mt8186- > > mt6366-rt1019-rt5682s.o > > This breaks bisection - these drivers are being added to the build > here > but the relevant source files aren't added until later on in the > series > so the commits in between won't build when the relevant Kconfig > options > are selected. The Makefile and Kconfig updates should be moved into > the > driver patches.
I see, this is to ensure the independence of each patch. I will move the Kconfig and Makefile changes related to the machine driver to the corresponding patch.
Thanks, Jiaxin.Yu
| |