lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4 1/1] nvme: handle persistent internal error AER from NVMe controller
Date
On 6/8/22 11:52, Michael Kelley wrote:
> In the NVM Express Revision 1.4 spec, Figure 145 describes possible
> values for an AER with event type "Error" (value 000b). For a
> Persistent Internal Error (value 03h), the host should perform a
> controller reset.
>
> Add support for this error using code that already exists for
> doing a controller reset. As part of this support, introduce
> two utility functions for parsing the AER type and subtype.
>
> This new support was tested in a lab environment where we can
> generate the persistent internal error on demand, and observe
> both the Linux side and NVMe controller side to see that the
> controller reset has been done.
>
> Signed-off-by: Michael Kelley <mikelley@microsoft.com>
> ---


Looks good. Thanks a lot for testing this, perhaps consider
writing the testcase for it in the blktests under nvme
category, that way it will get tested by everyone else.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck


\
 
 \ /
  Last update: 2022-06-09 02:23    [W:0.058 / U:3.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site