Messages in this thread | | | From | Chaitanya Kulkarni <> | Subject | Re: [PATCH v4 1/1] nvme: handle persistent internal error AER from NVMe controller | Date | Thu, 9 Jun 2022 00:22:45 +0000 |
| |
On 6/8/22 11:52, Michael Kelley wrote: > In the NVM Express Revision 1.4 spec, Figure 145 describes possible > values for an AER with event type "Error" (value 000b). For a > Persistent Internal Error (value 03h), the host should perform a > controller reset. > > Add support for this error using code that already exists for > doing a controller reset. As part of this support, introduce > two utility functions for parsing the AER type and subtype. > > This new support was tested in a lab environment where we can > generate the persistent internal error on demand, and observe > both the Linux side and NVMe controller side to see that the > controller reset has been done. > > Signed-off-by: Michael Kelley <mikelley@microsoft.com> > ---
Looks good. Thanks a lot for testing this, perhaps consider writing the testcase for it in the blktests under nvme category, that way it will get tested by everyone else.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
| |