lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[ammarfaizi2-block:stable/linux-stable-rc/queue/5.18 29/879] fs/cifs/connect.c:3435:14: warning: unused variable 'nodfs'
tree:   https://github.com/ammarfaizi2/linux-block stable/linux-stable-rc/queue/5.18
head: 7383156f95c8c7f7bda72abd7fa4d1bc06e2a8cf
commit: 98dd3927170845f16f5120686a0b5c5f181a3b87 [29/879] cifs: don't call cifs_dfs_query_info_nonascii_quirk() if nodfs was set
config: i386-randconfig-a001 (https://download.01.org/0day-ci/archive/20220609/202206090711.ZJTiUk4L-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/ammarfaizi2/linux-block/commit/98dd3927170845f16f5120686a0b5c5f181a3b87
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block stable/linux-stable-rc/queue/5.18
git checkout 98dd3927170845f16f5120686a0b5c5f181a3b87
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/cifs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

fs/cifs/connect.c: In function 'is_path_remote':
>> fs/cifs/connect.c:3435:14: warning: unused variable 'nodfs' [-Wunused-variable]
3435 | bool nodfs = cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NO_DFS;
| ^~~~~


vim +/nodfs +3435 fs/cifs/connect.c

3421
3422 /*
3423 * Check if path is remote (e.g. a DFS share). Return -EREMOTE if it is,
3424 * otherwise 0.
3425 */
3426 static int is_path_remote(struct mount_ctx *mnt_ctx)
3427 {
3428 int rc;
3429 struct cifs_sb_info *cifs_sb = mnt_ctx->cifs_sb;
3430 struct TCP_Server_Info *server = mnt_ctx->server;
3431 unsigned int xid = mnt_ctx->xid;
3432 struct cifs_tcon *tcon = mnt_ctx->tcon;
3433 struct smb3_fs_context *ctx = mnt_ctx->fs_ctx;
3434 char *full_path;
> 3435 bool nodfs = cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NO_DFS;
3436
3437 if (!server->ops->is_path_accessible)
3438 return -EOPNOTSUPP;
3439
3440 /*
3441 * cifs_build_path_to_root works only when we have a valid tcon
3442 */
3443 full_path = cifs_build_path_to_root(ctx, cifs_sb, tcon,
3444 tcon->Flags & SMB_SHARE_IS_IN_DFS);
3445 if (full_path == NULL)
3446 return -ENOMEM;
3447
3448 cifs_dbg(FYI, "%s: full_path: %s\n", __func__, full_path);
3449
3450 rc = server->ops->is_path_accessible(xid, tcon, cifs_sb,
3451 full_path);
3452 #ifdef CONFIG_CIFS_DFS_UPCALL
3453 if (nodfs) {
3454 if (rc == -EREMOTE)
3455 rc = -EOPNOTSUPP;
3456 goto out;
3457 }
3458
3459 /* path *might* exist with non-ASCII characters in DFS root
3460 * try again with full path (only if nodfs is not set) */
3461 if (rc == -ENOENT && is_tcon_dfs(tcon))
3462 rc = cifs_dfs_query_info_nonascii_quirk(xid, tcon, cifs_sb,
3463 full_path);
3464 #endif
3465 if (rc != 0 && rc != -EREMOTE)
3466 goto out;
3467
3468 if (rc != -EREMOTE) {
3469 rc = cifs_are_all_path_components_accessible(server, xid, tcon,
3470 cifs_sb, full_path, tcon->Flags & SMB_SHARE_IS_IN_DFS);
3471 if (rc != 0) {
3472 cifs_server_dbg(VFS, "cannot query dirs between root and final path, enabling CIFS_MOUNT_USE_PREFIX_PATH\n");
3473 cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_USE_PREFIX_PATH;
3474 rc = 0;
3475 }
3476 }
3477
3478 out:
3479 kfree(full_path);
3480 return rc;
3481 }
3482

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-06-09 01:15    [W:0.069 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site