Messages in this thread | | | Date | Wed, 8 Jun 2022 12:33:41 -0700 | From | Dhananjay Phadke <> | Subject | Re: [PATCH 5/5] crypto: aspeed: add HACE crypto driver |
| |
On 6/6/2022 8:43 PM, Neal Liu wrote: >>> +struct aspeed_hace_alg { >>> + struct aspeed_hace_dev *hace_dev; >>> + union { >>> + struct skcipher_alg skcipher; >>> + struct aead_alg aead; >>> + struct ahash_alg ahash; >>> + struct kpp_alg kpp; >>> + struct akcipher_alg akcipher; >> >> Your patch dont do any kpp or akcipher (and aead/skcipher also). >> Please drop this. > > I miss this part, I'll revise it in next patch, thanks.
Hi Neal,
Are you planning to submit aead separately? HW programming interface for aes-gcm is almost same as other aes modes except extra regs/fields for tag etc.
Thanks, Dhananjay
| |