Messages in this thread | | | From | Sedat Dilek <> | Date | Wed, 8 Jun 2022 21:29:44 +0200 | Subject | Re: [PATCH] perf unwind: Fix uninitialized variable |
| |
On Tue, Jun 7, 2022 at 8:12 PM Sedat Dilek <sedat.dilek@gmail.com> wrote: > > On Tue, Jun 7, 2022 at 2:09 AM Ian Rogers <irogers@google.com> wrote: > > > > ret may be uninitialized on error goto paths. > > > > Reported-by: Sedat Dilek <sedat.dilek@gmail.com> > > Fixes: dc2cf4ca866f ("perf unwind: Fix segbase for ld.lld linked objects") > > Signed-off-by: Ian Rogers <irogers@google.com> > > Thanks for the patch. > > Feel free to add my: > > Tested-by: Sedat Dilek <sedat.dilek@gmail.com> >
If it is not too late, more exactly:
Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
-Sedat-
> $ LC_ALL=C ll ~/bin/perf > -rwxr-xr-x 2 dileks dileks 16M Jun 7 20:10 /home/dileks/bin/perf > > $ ~/bin/perf -vv > perf version 5.19.0-rc1 > dwarf: [ on ] # HAVE_DWARF_SUPPORT > dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT > glibc: [ on ] # HAVE_GLIBC_SUPPORT > syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT > libbfd: [ on ] # HAVE_LIBBFD_SUPPORT > debuginfod: [ OFF ] # HAVE_DEBUGINFOD_SUPPORT > libelf: [ on ] # HAVE_LIBELF_SUPPORT > libnuma: [ on ] # HAVE_LIBNUMA_SUPPORT > numa_num_possible_cpus: [ on ] # HAVE_LIBNUMA_SUPPORT > libperl: [ on ] # HAVE_LIBPERL_SUPPORT > libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT > libslang: [ on ] # HAVE_SLANG_SUPPORT > libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT > libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT > libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT > zlib: [ on ] # HAVE_ZLIB_SUPPORT > lzma: [ on ] # HAVE_LZMA_SUPPORT > get_cpuid: [ on ] # HAVE_AUXTRACE_SUPPORT > bpf: [ on ] # HAVE_LIBBPF_SUPPORT > aio: [ on ] # HAVE_AIO_SUPPORT > zstd: [ on ] # HAVE_ZSTD_SUPPORT > libpfm4: [ OFF ] # HAVE_LIBPFM > > -Sedat- > > > --- > > tools/perf/util/unwind-libunwind-local.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c > > index 37622699c91a..6e5b8cce47bf 100644 > > --- a/tools/perf/util/unwind-libunwind-local.c > > +++ b/tools/perf/util/unwind-libunwind-local.c > > @@ -174,7 +174,7 @@ static int elf_section_address_and_offset(int fd, const char *name, u64 *address > > Elf *elf; > > GElf_Ehdr ehdr; > > GElf_Shdr shdr; > > - int ret; > > + int ret = -1; > > > > elf = elf_begin(fd, PERF_ELF_C_READ_MMAP, NULL); > > if (elf == NULL) > > -- > > 2.36.1.255.ge46751e96f-goog > >
| |