[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mtd: spi-nor: siliconkaiser: add support for sk25lp128
Hi Tom,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mtd/spi-nor/next]
[also build test WARNING on v5.19-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: spi-nor/next
config: arm-randconfig-c002-20220607 (
compiler: clang version 15.0.0 ( b92436efcb7813fc481b30f2593a4907568d917a)
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
git remote add linux-review
git fetch --no-tags linux-review Tom-Fitzhenry/mtd-spi-nor-siliconkaiser-add-support-for-sk25lp128/20220605-163120
git checkout 9ee4927880d43f8611d371e7cc7d8854a927de66
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/mtd/spi-nor/ drivers/nfc/nfcmrvl/ fs/quota/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <>

All warnings (new ones prefixed by >>):

drivers/mtd/spi-nor/siliconkaiser.c:8:18: error: call to undeclared function 'SNOR_ID3'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
{ "sk25lp128", SNOR_ID3(0x257018) },
>> drivers/mtd/spi-nor/siliconkaiser.c:8:18: warning: suggest braces around initialization of subobject [-Wmissing-braces]
{ "sk25lp128", SNOR_ID3(0x257018) },
{ }
drivers/mtd/spi-nor/siliconkaiser.c:8:18: error: initializer element is not a compile-time constant
{ "sk25lp128", SNOR_ID3(0x257018) },
1 warning and 2 errors generated.

vim +8 drivers/mtd/spi-nor/siliconkaiser.c

7 static const struct flash_info siliconkaiser_nor_parts[] = {
> 8 { "sk25lp128", SNOR_ID3(0x257018) },
9 };

0-DAY CI Kernel Test Service

 \ /
  Last update: 2022-06-08 21:28    [W:0.060 / U:1.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site