lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] drm/bridge: anx7625: Register Type-C mode switches
Hi Prashant,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm/drm-next]
[also build test WARNING on usb/usb-testing v5.19-rc1 next-20220608]
[cannot apply to balbi-usb/testing/next peter-chen-usb/for-usb-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Prashant-Malani/usb-typec-Introduce-typec-switch-binding/20220608-042545
base: git://anongit.freedesktop.org/drm/drm drm-next
config: i386-randconfig-a006 (https://download.01.org/0day-ci/archive/20220609/202206090139.lV7qgO5F-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b92436efcb7813fc481b30f2593a4907568d917a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/2ac4609c73d7bb4d1a585dae84559967ced3bad6
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Prashant-Malani/usb-typec-Introduce-typec-switch-binding/20220608-042545
git checkout 2ac4609c73d7bb4d1a585dae84559967ced3bad6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/bridge/analogix/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

In file included from drivers/gpu/drm/bridge/analogix/anx7625.c:18:
>> include/linux/usb/typec_mux.h:83:19: warning: no previous prototype for function 'fwnode_typec_mux_get' [-Wmissing-prototypes]
struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode,
^
include/linux/usb/typec_mux.h:83:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode,
^
static
>> include/linux/usb/typec_mux.h:89:6: warning: no previous prototype for function 'typec_mux_put' [-Wmissing-prototypes]
void typec_mux_put(struct typec_mux *mux) {}
^
include/linux/usb/typec_mux.h:89:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void typec_mux_put(struct typec_mux *mux) {}
^
static
>> include/linux/usb/typec_mux.h:91:5: warning: no previous prototype for function 'typec_mux_set' [-Wmissing-prototypes]
int typec_mux_set(struct typec_mux *mux, struct typec_mux_state *state)
^
include/linux/usb/typec_mux.h:91:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int typec_mux_set(struct typec_mux *mux, struct typec_mux_state *state)
^
static
>> include/linux/usb/typec_mux.h:103:1: warning: no previous prototype for function 'typec_mux_register' [-Wmissing-prototypes]
typec_mux_register(struct device *parent, const struct typec_mux_desc *desc)
^
include/linux/usb/typec_mux.h:102:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct typec_mux *
^
static
>> include/linux/usb/typec_mux.h:107:6: warning: no previous prototype for function 'typec_mux_unregister' [-Wmissing-prototypes]
void typec_mux_unregister(struct typec_mux *mux) {}
^
include/linux/usb/typec_mux.h:107:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void typec_mux_unregister(struct typec_mux *mux) {}
^
static
>> include/linux/usb/typec_mux.h:109:6: warning: no previous prototype for function 'typec_mux_set_drvdata' [-Wmissing-prototypes]
void typec_mux_set_drvdata(struct typec_mux *mux, void *data) {}
^
include/linux/usb/typec_mux.h:109:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void typec_mux_set_drvdata(struct typec_mux *mux, void *data) {}
^
static
>> include/linux/usb/typec_mux.h:110:7: warning: no previous prototype for function 'typec_mux_get_drvdata' [-Wmissing-prototypes]
void *typec_mux_get_drvdata(struct typec_mux *mux)
^
include/linux/usb/typec_mux.h:110:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void *typec_mux_get_drvdata(struct typec_mux *mux)
^
static
drivers/gpu/drm/bridge/analogix/anx7625.c:2617:23: error: incompatible pointer types assigning to 'struct typec_mux_dev *' from 'struct typec_mux *' [-Werror,-Wincompatible-pointer-types]
port_data->typec_mux = typec_mux_register(dev, &mux_desc);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/bridge/analogix/anx7625.c:2631:24: error: incompatible pointer types passing 'struct typec_mux_dev *' to parameter of type 'struct typec_mux *' [-Werror,-Wincompatible-pointer-types]
typec_mux_unregister(ctx->typec_ports[i].typec_mux);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/usb/typec_mux.h:107:45: note: passing argument to parameter 'mux' here
void typec_mux_unregister(struct typec_mux *mux) {}
^
7 warnings and 2 errors generated.


vim +/fwnode_typec_mux_get +83 include/linux/usb/typec_mux.h

0835afe6b807ae Prashant Malani 2022-06-07 82
0835afe6b807ae Prashant Malani 2022-06-07 @83 struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode,
0835afe6b807ae Prashant Malani 2022-06-07 84 const struct typec_altmode_desc *desc)
0835afe6b807ae Prashant Malani 2022-06-07 85 {
0835afe6b807ae Prashant Malani 2022-06-07 86 return ERR_PTR(-EOPNOTSUPP);
0835afe6b807ae Prashant Malani 2022-06-07 87 }
0835afe6b807ae Prashant Malani 2022-06-07 88
0835afe6b807ae Prashant Malani 2022-06-07 @89 void typec_mux_put(struct typec_mux *mux) {}
0835afe6b807ae Prashant Malani 2022-06-07 90
0835afe6b807ae Prashant Malani 2022-06-07 @91 int typec_mux_set(struct typec_mux *mux, struct typec_mux_state *state)
0835afe6b807ae Prashant Malani 2022-06-07 92 {
0835afe6b807ae Prashant Malani 2022-06-07 93 return -EOPNOTSUPP;
0835afe6b807ae Prashant Malani 2022-06-07 94 }
0835afe6b807ae Prashant Malani 2022-06-07 95
0835afe6b807ae Prashant Malani 2022-06-07 96 static inline struct typec_mux *
0835afe6b807ae Prashant Malani 2022-06-07 97 typec_mux_get(struct device *dev, const struct typec_altmode_desc *desc)
0835afe6b807ae Prashant Malani 2022-06-07 98 {
0835afe6b807ae Prashant Malani 2022-06-07 99 return ERR_PTR(-EOPNOTSUPP);
0835afe6b807ae Prashant Malani 2022-06-07 100 }
0835afe6b807ae Prashant Malani 2022-06-07 101
0835afe6b807ae Prashant Malani 2022-06-07 102 struct typec_mux *
0835afe6b807ae Prashant Malani 2022-06-07 @103 typec_mux_register(struct device *parent, const struct typec_mux_desc *desc)
0835afe6b807ae Prashant Malani 2022-06-07 104 {
0835afe6b807ae Prashant Malani 2022-06-07 105 return ERR_PTR(-EOPNOTSUPP);
0835afe6b807ae Prashant Malani 2022-06-07 106 }
0835afe6b807ae Prashant Malani 2022-06-07 @107 void typec_mux_unregister(struct typec_mux *mux) {}
0835afe6b807ae Prashant Malani 2022-06-07 108
0835afe6b807ae Prashant Malani 2022-06-07 @109 void typec_mux_set_drvdata(struct typec_mux *mux, void *data) {}
0835afe6b807ae Prashant Malani 2022-06-07 @110 void *typec_mux_get_drvdata(struct typec_mux *mux)
0835afe6b807ae Prashant Malani 2022-06-07 111 {
0835afe6b807ae Prashant Malani 2022-06-07 112 return ERR_PTR(-EOPNOTSUPP);
0835afe6b807ae Prashant Malani 2022-06-07 113 }
0835afe6b807ae Prashant Malani 2022-06-07 114

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-06-08 20:20    [W:0.127 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site