lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 1/2] x86/fpu: Add a helper to prepare AMX state for low-power CPU idle
    Date
    When a CPU enters an idle state, a non-initialized AMX register state may
    be the cause of preventing a deeper low-power state. Other extended
    register states whether initialized or not do not impact the CPU idle
    state.

    The new helper can ensure the AMX state is initialized before the CPU is
    idle, and it will be used by the intel idle driver.

    Check the AMX_TILE feature bit before using XGETBV1 as a chain of
    dependencies was established via cpuid_deps[]: AMX->XFD->XGETBV1.

    Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
    Cc: x86@kernel.org
    Cc: linux-kernel@vger.kernel.org
    Cc: Rik van Riel <riel@fb.com>
    Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Fenghua Yu <fenghua.yu@intel.com>
    ---
    Changes from v4:
    * Switch to check the AMX_TILE flag instead XGETBV1 (Dave Hansen).
    * Massage the changelog.

    Changes from v3:
    * Call out AMX state in changelog (Thomas Glexiner).

    Changes from v2:
    * Check the feature flag instead of fpu_state_size_dynamic() (Dave Hansen).

    Changes from v1:
    * Check the dynamic state flag first, to avoid #UD with XGETBV(1).
    ---
    arch/x86/include/asm/fpu/api.h | 2 ++
    arch/x86/include/asm/special_insns.h | 9 +++++++++
    arch/x86/kernel/fpu/core.c | 14 ++++++++++++++
    3 files changed, 25 insertions(+)

    diff --git a/arch/x86/include/asm/fpu/api.h b/arch/x86/include/asm/fpu/api.h
    index 6b0f31fb53f7..503a577814b2 100644
    --- a/arch/x86/include/asm/fpu/api.h
    +++ b/arch/x86/include/asm/fpu/api.h
    @@ -164,4 +164,6 @@ static inline bool fpstate_is_confidential(struct fpu_guest *gfpu)
    /* prctl */
    extern long fpu_xstate_prctl(int option, unsigned long arg2);

    +extern void fpu_idle_fpregs(void);
    +
    #endif /* _ASM_X86_FPU_API_H */
    diff --git a/arch/x86/include/asm/special_insns.h b/arch/x86/include/asm/special_insns.h
    index 45b18eb94fa1..35f709f619fb 100644
    --- a/arch/x86/include/asm/special_insns.h
    +++ b/arch/x86/include/asm/special_insns.h
    @@ -295,6 +295,15 @@ static inline int enqcmds(void __iomem *dst, const void *src)
    return 0;
    }

    +static inline void tile_release(void)
    +{
    + /*
    + * Instruction opcode for TILERELEASE; supported in binutils
    + * version >= 2.36.
    + */
    + asm volatile(".byte 0xc4, 0xe2, 0x78, 0x49, 0xc0");
    +}
    +
    #endif /* __KERNEL__ */

    #endif /* _ASM_X86_SPECIAL_INSNS_H */
    diff --git a/arch/x86/kernel/fpu/core.c b/arch/x86/kernel/fpu/core.c
    index 0531d6a06df5..3b28c5b25e12 100644
    --- a/arch/x86/kernel/fpu/core.c
    +++ b/arch/x86/kernel/fpu/core.c
    @@ -851,3 +851,17 @@ int fpu__exception_code(struct fpu *fpu, int trap_nr)
    */
    return 0;
    }
    +
    +/*
    + * Initialize register state that may prevent from entering low-power idle.
    + * This function will be invoked from the cpuidle driver only when needed.
    + */
    +void fpu_idle_fpregs(void)
    +{
    + /* Note: AMX_TILE being enabled implies XGETBV1 support */
    + if (cpu_feature_enabled(X86_FEATURE_AMX_TILE) &&
    + (xfeatures_in_use() & XFEATURE_MASK_XTILE)) {
    + tile_release();
    + fpregs_deactivate(&current->thread.fpu);
    + }
    +}
    --
    2.17.1
    \
     
     \ /
      Last update: 2022-06-08 19:16    [W:4.615 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site