lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 02/17] regmap-irq: Add get_irq_reg to support unusual register layouts
On Tue, Jun 07, 2022 at 04:53:09PM +0100, Aidan MacDonald wrote:

> - if (!chip->sub_reg_offsets || !chip->not_fixed_stride) {
> + if (chip->get_irq_reg) {
> + reg = chip->get_irq_reg(base_reg, i);
> + } else if (!chip->sub_reg_offsets || !chip->not_fixed_stride) {

It seems like it would be cleaner and clearer to refactor things so that
we always have a get_irq_reg() with standard chips getting given a
default implementation which implements the current behaviour.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-06-08 18:22    [W:0.175 / U:1.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site