Messages in this thread | | | Date | Tue, 7 Jun 2022 19:28:08 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 3/6] bitops: define gen_test_bit() the same way as the rest of functions |
| |
On Tue, Jun 07, 2022 at 05:57:22PM +0200, Alexander Lobakin wrote: > From: Marco Elver <elver@google.com> > Date: Tue, 7 Jun 2022 15:43:49 +0200 > > On Mon, Jun 06, 2022 at 01:49PM +0200, Alexander Lobakin wrote:
...
> > I would also propose adding a comment close to the deref that test_bit() > > is atomic and the deref needs to remain volatile, so future people will > > not try to do the same optimization. > > I think that's also the reason why it's not underscored, right?
Non-__ prefixed bitops are atomic, __ non-atomic.
-- With Best Regards, Andy Shevchenko
| |