lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] nvme: add device name to warning in uuid_show()
On Tue, Jun 07, 2022 at 05:55:55PM +0200, Thomas Weißschuh wrote:
> if (uuid_is_null(&ids->uuid)) {
> - printk_ratelimited(KERN_WARNING
> - "No UUID available providing old NGUID\n");
> + dev_warn_ratelimited(dev, "No UUID available providing old NGUID\n");
> return sysfs_emit(buf, "%pU\n", ids->nguid);

The line split was correct to prevent this overly long line. But otherwise,
this looks good, though I'm wondering why this needs to be printed every time
someone reads the attribute.

\
 
 \ /
  Last update: 2022-06-07 18:12    [W:0.043 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site