Messages in this thread |  | | From | Tzung-Bi Shih <> | Subject | [PATCH v2 00/15] platform/chrome: Kunit tests and refactor for cros_ec_query_all() | Date | Tue, 7 Jun 2022 14:56:24 +0000 |
| |
The series adds Kunit tests, refactors, and clean-ups for cros_ec_query_all().
Tzung-Bi Shih (15): platform/chrome: cros_ec_commands: fix compile errors -> Fixes compile errors when including cros_ec_commands.h.
platform/chrome: cros_ec_proto: add Kunit tests for cros_ec_query_all() -> Adds Kunit tests for cros_ec_query_all(). They are baseline tests for the following refactor patches.
platform/chrome: use macros for passthru indexes platform/chrome: cros_ec_proto: assign buffer size from protocol info -> Refactors.
platform/chrome: cros_ec_proto: remove redundant NULL check -> Clean up.
platform/chrome: cros_ec_proto: use cros_ec_map_error() -> Changes the internal return code.
platform/chrome: cros_ec_proto: separate cros_ec_get_proto_info() platform/chrome: cros_ec_proto: handle empty payload in getting proto info platform/chrome: cros_ec_proto: separate cros_ec_get_proto_info_legacy() platform/chrome: cros_ec_proto: handle empty payload in getting info legacy -> Check if send_command() returns negative integer. Call cros_ec_map_error() to see if msg->result isn't EC_RES_SUCCESS. Report -EPROTO if send_command() returns 0.
platform/chrome: cros_ec: don't allocate `din` and `dout` in cros_ec_register() -> Clean up.
platform/chrome: use krealloc() for `din` and `dout` -> Replace devm variant to non-devm.
platform/chrome: cros_ec_proto: don't show MKBP version if unsupported -> Minor fix up.
platform/chrome: cros_ec_proto: return 0 on getting version mask success platform/chrome: cros_ec_proto: return 0 on getting wake mask success -> Conform to kernel convention: return 0 on success; otherwise, negative integers.
drivers/platform/chrome/Kconfig | 6 + drivers/platform/chrome/Makefile | 1 + drivers/platform/chrome/cros_ec.c | 17 +- drivers/platform/chrome/cros_ec_proto.c | 318 ++-- drivers/platform/chrome/cros_ec_proto_test.c | 1400 +++++++++++++++++ drivers/platform/chrome/cros_ec_trace.h | 8 +- drivers/platform/chrome/cros_kunit_util.c | 98 ++ drivers/platform/chrome/cros_kunit_util.h | 36 + .../linux/platform_data/cros_ec_commands.h | 4 +- include/linux/platform_data/cros_ec_proto.h | 3 + 10 files changed, 1713 insertions(+), 178 deletions(-) create mode 100644 drivers/platform/chrome/cros_kunit_util.c create mode 100644 drivers/platform/chrome/cros_kunit_util.h
Changes from v1: (https://patchwork.kernel.org/project/chrome-platform/cover/20220606141051.285823-1-tzungbi@kernel.org/) - Fix review comments. - Split and reorder patches.
-- 2.36.1.255.ge46751e96f-goog
|  |