lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 16/36] tty/vt: consolemap: check put_user() in con_get_unimap()
    On Tue, 7 Jun 2022, Jiri Slaby wrote:

    > Only the return value of copy_to_user() is checked in con_get_unimap().
    > Do the same for put_user() of the count too.
    >
    > Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    > ---
    > drivers/tty/vt/consolemap.c | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c
    > index 831450f2bfd1..92b5dddb00d9 100644
    > --- a/drivers/tty/vt/consolemap.c
    > +++ b/drivers/tty/vt/consolemap.c
    > @@ -813,7 +813,8 @@ int con_get_unimap(struct vc_data *vc, ushort ct, ushort __user *uct,
    > console_unlock();
    > if (copy_to_user(list, unilist, min(ect, ct) * sizeof(*unilist)))
    > ret = -EFAULT;
    > - put_user(ect, uct);
    > + if (put_user(ect, uct))
    > + ret = -EFAULT;
    > kvfree(unilist);
    > return ret ? ret : (ect <= ct) ? 0 : -ENOMEM;
    > }
    >

    Doesn't this fix something?

    --
    i.

    \
     
     \ /
      Last update: 2022-06-07 16:28    [W:2.586 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site