Messages in this thread | | | Date | Tue, 7 Jun 2022 17:11:05 +0300 (EEST) | From | Ilpo Järvinen <> | Subject | Re: [PATCH 14/36] tty/vt: consolemap: make con_get_unimap() more readable |
| |
On Tue, 7 Jun 2022, Jiri Slaby wrote:
> The indentation is completely broken in con_get_unimap(). Reorder the > code using "if (!cond) continue;"s so that the code makes sense. Switch > also the "p" assignment and add a short path using goto. This makes the > code readable again. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
-- i.
| |