Messages in this thread | | | From | Luiz Angelo Daros de Luca <> | Date | Tue, 7 Jun 2022 10:34:38 -0300 | Subject | Re: [PATCH net-next 2/5] net: dsa: realtek: rtl8365mb: remove port_mask private data member |
| |
> There is no real need for this variable: the line change interrupt mask > is sufficiently masked out when getting linkup_ind and linkdown_ind in > the interrupt handler.
Yes, it was currently useless as well as priv->num_ports (it is a constant).
I wonder if we should really create irq threads for unused ports (!dsa_is_unused_port()). Some models have only 2+1 ports and we are always dealing with 10/11 ports. If dsa_is_unused_port() is too costly to be used everywhere, we could keep port_mask and iterate over it (for_each_set_bit) instead of from 0 til priv->num_ports-1.
Regards,
Luiz
| |