Messages in this thread | | | From | Krzysztof Kozlowski <> | Subject | Re: (subset) [PATCH v3 6/8] arm64: dts: fsd: use local header for pinctrl register values | Date | Tue, 7 Jun 2022 08:39:14 +0200 |
| |
On Sun, 5 Jun 2022 18:05:06 +0200, Krzysztof Kozlowski wrote: > The DTS uses hardware register values directly in pin controller pin > configuration. These are not some IDs or other abstraction layer but > raw numbers used in the registers. > > These numbers were previously put in the bindings header to avoid code > duplication and to provide some context meaning (name), but they do not > fit the purpose of bindings. It is also quite confusing to use > constants prefixed with Exynos for other SoC, because there is actually > nothing here in common, except the actual value. > > [...]
Applied, thanks!
[6/8] arm64: dts: fsd: use local header for pinctrl register values https://git.kernel.org/krzk/linux/c/2a795ade7740a3217eb2b08179479018c5bf25dd
Best regards, -- Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
| |