Messages in this thread | | | Date | Tue, 7 Jun 2022 13:35:06 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/3] ASoC: wm8940: Remove warning when no plat data |
| |
On Tue, Jun 07, 2022 at 02:30:39PM +0200, Lukasz Majewski wrote: > > On Mon, Jun 06, 2022 at 06:17:31PM +0200, Lukasz Majewski wrote: > > > > On Mon, Jun 06, 2022 at 05:44:39PM +0200, Lukasz Majewski wrote:
> > > My point is that - similar codec - wm8974 don't display such > > > warnings. (this code was not updated/refactored for a quite long > > > time).
> > Perhaps those drivers are buggy, or those devices lack this specific > > configuration that's being adjusted? The changelog should at least > > address why the driver was warning about configuration being required > > but it's safe to ignore that.
> With v4.4 from which I forward port those changes only the PXA > 'stargate2' mach is using this codec.
> In this version there is no reference to 'vroi'.
That's equivalent to setting a value of 0 given the way platform data works.
> I guess that one can provide the 'vroi' information via DTS nowadays if > required.
Yes, that's what I'd expect. [unhandled content-type:application/pgp-signature] | |