lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 4/6] mm: Demote warning message in vmemmap_verify() to debug level
From
On 07.06.22 11:38, Wupeng Ma wrote:
> From: Ma Wupeng <mawupeng1@huawei.com>
>
> For a system only have limited mirrored memory or some numa node without
> mirrored memory, the per node vmemmap page_structs prefer to allocate
> memory from mirrored region, which will lead to vmemmap_verify() in
> vmemmap_populate_basepages() report lots of warning message.
>
> This patch demote the "potential offnode page_structs" warning messages
> to debug level to avoid a very long print during bootup.
>
> Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
> ---
> mm/sparse-vmemmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c
> index f4fa61dbbee3..78debdb89eb1 100644
> --- a/mm/sparse-vmemmap.c
> +++ b/mm/sparse-vmemmap.c
> @@ -528,7 +528,7 @@ void __meminit vmemmap_verify(pte_t *pte, int node,
> int actual_node = early_pfn_to_nid(pfn);
>
> if (node_distance(actual_node, node) > LOCAL_DISTANCE)
> - pr_warn("[%lx-%lx] potential offnode page_structs\n",
> + pr_debug("[%lx-%lx] potential offnode page_structs\n",
> start, end - 1);
> }
>

This will possibly hide it in environments where this might indeed
indicate performance issues.

What about a pr_warn_once()?

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2022-06-07 14:27    [W:0.208 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site