lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v17 10/10] ARM: dts: Add Sunplus SP7021-Demo-V3 board device tree
From
On 07/06/2022 03:58, Qin Jian wrote:
> Add the basic support for Sunplus SP7021-Demo-V3 board.
>
> Signed-off-by: Qin Jian <qinjian@cqplus1.com>
> ---
> Fix the comments from Krzysztof.
> ---

> +
> + pctl: pinctl@9c000100 {

Wrong node name - the schema requires "pinctrl" or "pinmux".

> + compatible = "sunplus,sp7021-pctl";
> + reg = <0x9C000100 0x100>,
> + <0x9C000300 0x100>,
> + <0x9C0032e4 0x1C>,
> + <0x9C000080 0x20>;
> + reg-names = "moon2", "gpioxt", "first", "moon1";
> + gpio-controller;
> + #gpio-cells = <2>;
> + clocks = <&clkc CLK_GPIO>;
> + resets = <&rstc RST_GPIO>;
> +
> + leds_pins: pinmux_gpio_leds-pins {
> + sunplus,pins = < SPPCTL_IOPAD(0,SPPCTL_PCTL_G_GPIO,0,SPPCTL_PCTL_L_OUT) >;
> + };
> +
> + emmc_pins: emmc-pins {
> + function = "CARD0_EMMC";
> + groups = "CARD0_EMMC";
> + };
> +
> + sdcard-pins {
> + function = "SD_CARD";
> + groups = "SD_CARD";
> + sunplus,pins = < SPPCTL_IOPAD(91, SPPCTL_PCTL_G_GPIO, 0, 0) >;
> + };
> +
> + emac_pins: pinmux_emac_demo_board_v3-pins {
> + sunplus,pins = <
> + SPPCTL_IOPAD(49,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_CLK_OUT,0)
> + SPPCTL_IOPAD(44,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_MAC_SMI_MDC,0)
> + SPPCTL_IOPAD(43,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_MAC_SMI_MDIO,0)
> + SPPCTL_IOPAD(52,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_TXEN,0)
> + SPPCTL_IOPAD(50,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_TXD0,0)
> + SPPCTL_IOPAD(51,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_TXD1,0)
> + SPPCTL_IOPAD(46,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_CRSDV,0)
> + SPPCTL_IOPAD(47,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_RXD0,0)
> + SPPCTL_IOPAD(48,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_RXD1,0)
> + SPPCTL_IOPAD(45,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_RXER,0)
> + SPPCTL_IOPAD(59,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_TXEN,0)
> + SPPCTL_IOPAD(57,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_TXD0,0)
> + SPPCTL_IOPAD(58,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_TXD1,0)
> + SPPCTL_IOPAD(54,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_CRSDV,0)
> + SPPCTL_IOPAD(55,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_RXD0,0)
> + SPPCTL_IOPAD(56,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_RXD1,0)
> + SPPCTL_IOPAD(53,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_RXER,0)
> + >;
> + sunplus,zerofunc = <
> + MUXF_L2SW_LED_FLASH0
> + MUXF_L2SW_LED_FLASH1
> + MUXF_L2SW_LED_ON0
> + MUXF_L2SW_LED_ON1
> + MUXF_DAISY_MODE
> + >;
> + };
> +
> + uart0_pins: pinmux_uart0-pins {
> + function = "UA0";
> + groups = "UA0";
> + };
> +
> + uart1_pins: pinmux_uart1-pins {

No underscores in node names.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-06-07 14:03    [W:0.218 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site