lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 04/13] can: slcan: use CAN network device driver API
    On 07.06.2022 11:47:43, Dario Binacchi wrote:
    > As suggested by commit [1], now the driver uses the functions and the
    > data structures provided by the CAN network device driver interface.
    >
    > There is no way to set bitrate for SLCAN based devices via ip tool, so
    ^^^^^^^^^^^^^^^
    Currently the driver doesn't implement a way

    > you'll have to do this by slcand/slcan_attach invocation through the
    > -sX parameter:
    >
    > - slcan_attach -f -s6 -o /dev/ttyACM0
    > - slcand -f -s8 -o /dev/ttyUSB0
    >
    > where -s6 in will set adapter's bitrate to 500 Kbit/s and -s8 to
    > 1Mbit/s.
    > See the table below for further CAN bitrates:
    > - s0 -> 10 Kbit/s
    > - s1 -> 20 Kbit/s
    > - s2 -> 50 Kbit/s
    > - s3 -> 100 Kbit/s
    > - s4 -> 125 Kbit/s
    > - s5 -> 250 Kbit/s
    > - s6 -> 500 Kbit/s
    > - s7 -> 800 Kbit/s
    > - s8 -> 1000 Kbit/s
    >
    > In doing so, the struct can_priv::bittiming.bitrate of the driver is not
    > set and since the open_candev() checks that the bitrate has been set, it
    > must be a non-zero value, the bitrate is set to a fake value (-1) before
    > it is called.

    What does

    | ip --details -s -s link show

    show as the bit rate?

    Marc

    --
    Pengutronix e.K. | Marc Kleine-Budde |
    Embedded Linux | https://www.pengutronix.de |
    Vertretung West/Dortmund | Phone: +49-231-2826-924 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2022-06-07 13:15    [W:4.912 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site