lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 548/879] arm64: dts: qcom: sc7280-herobrine: Drop outputs on fpmcu pins
    Date
    From: Stephen Boyd <swboyd@chromium.org>

    [ Upstream commit dbcbeed94f3b6f7f24349a7f335cc603a682e7a7 ]

    Having these pins with outputs is good on a fresh boot because it puts
    the boot and reset pins in a known "good" state. Unfortunately, that
    conflicts with the fingerprint firmware flashing code. The firmware
    flashing process binds and unbinds the cros-ec and spidev drivers and
    that reapplies the pin output values after the flashing code has
    overridden the gpio values. This causes a problem because we try to put
    the device into bootloader mode, bind the spidev driver and that
    inadvertently puts it right back into normal boot mode, breaking the
    flashing process.

    Fix this by removing the outputs. We'll introduce a binding for
    fingerprint cros-ec specifically to set the gpios properly via gpio APIs
    during cros-ec driver probe instead.

    Cc: Douglas Anderson <dianders@chromium.org>
    Cc: Matthias Kaehlcke <mka@chromium.org>
    Cc: Alexandru M Stan <amstan@chromium.org>
    Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1")
    Signed-off-by: Stephen Boyd <swboyd@chromium.org>
    Reviewed-by: Douglas Anderson <dianders@chromium.org>
    Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Link: https://lore.kernel.org/r/20220317010640.2498502-2-swboyd@chromium.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
    index 7b8fe20afcea..488caa48cba3 100644
    --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
    +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
    @@ -677,7 +677,6 @@ ap_ec_spi: &spi10 {
    function = "gpio";
    bias-disable;
    drive-strength = <2>;
    - output-high;
    };

    fp_to_ap_irq_l: fp-to-ap-irq-l {
    @@ -691,7 +690,6 @@ ap_ec_spi: &spi10 {
    pins = "gpio68";
    function = "gpio";
    bias-disable;
    - output-low;
    };

    gsc_ap_int_odl: gsc-ap-int-odl {
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-17 16:25    [W:2.311 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site