Messages in this thread | | | Date | Tue, 7 Jun 2022 16:14:13 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH v4] net: ethernet: mtk_eth_soc: fix misuse of mem alloc interface netdev[napi]_alloc_frag |
| |
On Tue, 7 Jun 2022 07:39:11 +0800 Chen Lin wrote: > +static inline void *mtk_max_lro_buf_alloc(gfp_t gfp_mask)
No need for inline, compiler will inline this anyway.
> +{ > + void *data;
unsigned long data; then you can move the cast from the long line to the return statement, saving us from the strange indentation.
> + data = (void *)__get_free_pages(gfp_mask | > + __GFP_COMP | __GFP_NOWARN, > + get_order(mtk_max_frag_size(MTK_MAX_LRO_RX_LENGTH))); > + > + return data; > +}
| |