lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 612/879] ASoC: atmel-pdmic: Remove endianness flag on pdmic component
    Date
    From: Charles Keepax <ckeepax@opensource.cirrus.com>

    [ Upstream commit 52857c3baa0e5ddeba7b2c84e56bb71c9674e048 ]

    The endianness flag should have been removed when the driver was
    ported across from having both a CODEC and CPU side component, to
    just having a CPU component and using the dummy for the CODEC. The
    endianness flag is used to indicate that the device is completely
    ambivalent to the endianness of the data, typically due to the
    endianness being lost over the hardware link (ie. the link defines
    bit ordering). It's usage didn't have any effect when the driver
    had both a CPU and CODEC component, since the union of those equals
    the CPU side settings, but now causes the driver to falsely report
    it supports big endian. Correct this by removing the flag.

    Fixes: f3c668074a04 ("ASoC: atmel-pdmic: remove codec component")
    Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
    Link: https://lore.kernel.org/r/20220504170905.332415-3-ckeepax@opensource.cirrus.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/atmel/atmel-pdmic.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/sound/soc/atmel/atmel-pdmic.c b/sound/soc/atmel/atmel-pdmic.c
    index 42117de299e7..ea34efac2fff 100644
    --- a/sound/soc/atmel/atmel-pdmic.c
    +++ b/sound/soc/atmel/atmel-pdmic.c
    @@ -481,7 +481,6 @@ static const struct snd_soc_component_driver atmel_pdmic_cpu_dai_component = {
    .num_controls = ARRAY_SIZE(atmel_pdmic_snd_controls),
    .idle_bias_on = 1,
    .use_pmdown_time = 1,
    - .endianness = 1,
    };

    /* ASoC sound card */
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 04:50    [W:4.838 / U:0.712 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site