lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 783/879] selftests/landlock: Add tests for O_PATH
    Date
    From: Mickaël Salaün <mic@digikod.net>

    commit d1788ad990874734341b05ab8ccb6448c09c6422 upstream.

    The O_PATH flag is currently not handled by Landlock. Let's make sure
    this behavior will remain consistent with the same ruleset over time.

    Cc: Shuah Khan <shuah@kernel.org>
    Link: https://lore.kernel.org/r/20220506160820.524344-8-mic@digikod.net
    Cc: stable@vger.kernel.org
    Signed-off-by: Mickaël Salaün <mic@digikod.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    tools/testing/selftests/landlock/fs_test.c | 10 ++++++++--
    1 file changed, 8 insertions(+), 2 deletions(-)

    --- a/tools/testing/selftests/landlock/fs_test.c
    +++ b/tools/testing/selftests/landlock/fs_test.c
    @@ -654,17 +654,23 @@ TEST_F_FORK(layout1, effective_access)
    enforce_ruleset(_metadata, ruleset_fd);
    ASSERT_EQ(0, close(ruleset_fd));

    - /* Tests on a directory. */
    + /* Tests on a directory (with or without O_PATH). */
    ASSERT_EQ(EACCES, test_open("/", O_RDONLY));
    + ASSERT_EQ(0, test_open("/", O_RDONLY | O_PATH));
    ASSERT_EQ(EACCES, test_open(dir_s1d1, O_RDONLY));
    + ASSERT_EQ(0, test_open(dir_s1d1, O_RDONLY | O_PATH));
    ASSERT_EQ(EACCES, test_open(file1_s1d1, O_RDONLY));
    + ASSERT_EQ(0, test_open(file1_s1d1, O_RDONLY | O_PATH));
    +
    ASSERT_EQ(0, test_open(dir_s1d2, O_RDONLY));
    ASSERT_EQ(0, test_open(file1_s1d2, O_RDONLY));
    ASSERT_EQ(0, test_open(dir_s1d3, O_RDONLY));
    ASSERT_EQ(0, test_open(file1_s1d3, O_RDONLY));

    - /* Tests on a file. */
    + /* Tests on a file (with or without O_PATH). */
    ASSERT_EQ(EACCES, test_open(dir_s2d2, O_RDONLY));
    + ASSERT_EQ(0, test_open(dir_s2d2, O_RDONLY | O_PATH));
    +
    ASSERT_EQ(0, test_open(file1_s2d2, O_RDONLY));

    /* Checks effective read and write actions. */

    \
     
     \ /
      Last update: 2022-06-08 04:50    [W:4.020 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site