lkml.org 
[lkml]   [2022]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 512/879] amt: fix memory leak for advertisement message
    Date
    From: Taehee Yoo <ap420073@gmail.com>

    [ Upstream commit fe29794c3585d039fefebaa2b5a4932a627ad4fd ]

    When a gateway receives an advertisement message, it extracts relay
    information and then it should be freed.
    But the advertisement handler doesn't free it.
    So, memory leak would occur.

    Fixes: cbc21dc1cfe9 ("amt: add data plane of amt interface")
    Signed-off-by: Taehee Yoo <ap420073@gmail.com>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/amt.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/amt.c b/drivers/net/amt.c
    index 2b4ce3869f08..de4ea518c793 100644
    --- a/drivers/net/amt.c
    +++ b/drivers/net/amt.c
    @@ -2698,9 +2698,8 @@ static int amt_rcv(struct sock *sk, struct sk_buff *skb)
    err = true;
    goto drop;
    }
    - if (amt_advertisement_handler(amt, skb))
    - amt->dev->stats.rx_dropped++;
    - goto out;
    + err = amt_advertisement_handler(amt, skb);
    + break;
    case AMT_MSG_MULTICAST_DATA:
    if (iph->saddr != amt->remote_ip) {
    netdev_dbg(amt->dev, "Invalid Relay IP\n");
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-08 04:50    [W:4.028 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site